Code refinement 

if (newPrimaryOfferId != null) {
    if (restrictedPrimaryOffersForSelectionSO.getOfferIds().contains(newPrimaryOfferId)) {
        PrimaryOfferCannotSelectSOException ex = PrimaryOfferCannotSelectSOException.builder()
                .offeringName(offerResponse.getPrimaryOffering().getOfferingName())
                .build();
        log.error("ActionLog.getMsisdnDetails.error ex", ex);
        throw ex;
    }
} else {
    if (restrictedPrimaryOffersForSelectionSO.getOfferIds().contains(primaryOfferId)) {
        PrimaryOfferCannotSelectSOException ex = PrimaryOfferCannotSelectSOException.builder()
                .offeringName(offerResponse.getPrimaryOffering().getOfferingName())
                .build();
        log.error("ActionLog.getMsisdnDetails.error ex", ex);
        throw ex;
    }
}
offersInfos = mnoProductClient.getOfferListByTypeForSalesApp("az", ProviderTypes.Azerfon.getKey(),

OfferType.SO).getData(); 


to this:

if (newPrimaryOfferId != null && restrictedPrimaryOffersForSelectionSO.getOfferIds().contains(newPrimaryOfferId)
        || newPrimaryOfferId == null && restrictedPrimaryOffersForSelectionSO.getOfferIds().contains(primaryOfferId)) {
    throw  PrimaryOfferCannotSelectSOException.builder()
            .offeringName(offerResponse.getPrimaryOffering().getOfferingName())
            .build();
}

offersInfos = mnoProductClient.getOfferListByTypeForSalesApp("az", ProviderTypes.Azerfon.getKey(),
        OfferType.SO).getData();



















Комментарии

Отправить комментарий

Популярные сообщения из этого блога

Lesson1: JDK, JVM, JRE

Изображение
1. Compiler - takes the entire programming code written in high language and translates the whole of it into machine code at once. After this process the an executable file will be ready to run. The translation takes some times to be done, but after that execution is so fast. 2. Interpreter - takes each single instructions of the code translates it and then executes it on its own. The translation step is before the program runs is fast, but execution is slow. JDK = JRE + development tools JRE = JVM + library class JDK -> Java Development Kit. A kit which provides the environment to develop and execute (run) Java program. JRE -> Java Runtime Environment. Provides environment to only run. JVM -> Java Virtual Machine f * Compiled: Fortran, C, C++, Pascal, Haskell, Rust, Go * Interpreted: JavaScript, PHP, Python, Ruby Java both compiled and interpreted language. Terminalda : javac Main.java yazdiqda, source fayli(.java) bytecode(.class) faylina cevirir. Terminalda: java Main (bu z...
Далее...

SE_21_Lesson_9: Initialization Blocks, Wrapper types, String class

Изображение
-> static block: package org.example.test3 ; public class Blocks { static { System . out .println( "In static block" ) ; } public static void method () { System . out .println( "In static method" ) ; } } package org.example.test3 ; public class Main { public static void main ( String [] args ) { Blocks . method () ; } } -> Class.forName() metodunu ishe salmaq: package org.example.test3 ; public class Blocks { static { System . out .println( "In static block" ) ; } } package org.example.test3 ; public class Main { public static void main ( String [] args ) throws Exception { Class . forName ( "org.example.test3.Blocks" ) ; } } -> non-static (instance) block: package org.example.test3 ; public class Blocks { static { System . out .println( "in static block" ) ; } { System . out .println( "in non static (instance) block...
Далее...

SE_21_Lesson_11: Inheritance, Polymorphism

->  instanceof anlayishi, misallarla izahi   package org.example.lesson_13 ; public class Ulubaba { public String ad ; public String soyad ; public Integer yash ; public void odunDogramaq () { System . out .println( "Ulubaba 50 kq odunu 1 saata dograyir" ) ; } } package org.example.lesson_13 ; public class Baba extends Ulubaba { public String hobbi ; public void otBicmek () { System . out .println( "Baba 1 hektar otu 1 gune bicir" ) ; } } package org.example.lesson_13 ; public class Main { public static void main ( String [] args ) { Baba baba = new Baba() ; System . out .println( baba instanceof Ulubaba ) ; System . out .println( baba instanceof Object ) ; } } -> Upcasting package org.example.lesson_13 ; public class Main { public static void main ( String [] args ) { Ulubaba u = new Baba() ; } } -> Downcasting Problemsiz situasiya: package org.example.lesson_13...
Далее...